Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Fresh with our own websocket implementation #56

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

mruoss
Copy link
Owner

@mruoss mruoss commented Dec 23, 2024

No description provided.

@mruoss mruoss force-pushed the connect-refactoring branch 2 times, most recently from 736c7ea to a9e8322 Compare December 23, 2024 21:20
@coveralls
Copy link

coveralls commented Dec 23, 2024

Pull Request Test Coverage Report for Build bd8198874b0e625a3126f3225d827a97cadbfab0-PR-56

Details

  • 54 of 95 (56.84%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.2%) to 64.734%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/kubereq/pod_exec.ex 5 7 71.43%
lib/kubereq/pod_logs.ex 4 8 50.0%
lib/kubereq/connect.ex 45 80 56.25%
Totals Coverage Status
Change from base Build 3e4fb289491726827e0c9830e4c1f6da2bf4f619: -2.2%
Covered Lines: 402
Relevant Lines: 621

💛 - Coveralls

@mruoss mruoss force-pushed the connect-refactoring branch from a9e8322 to 9787adb Compare December 24, 2024 11:53
@mruoss mruoss force-pushed the connect-refactoring branch from 9787adb to bd81988 Compare December 24, 2024 11:53
@mruoss mruoss merged commit df7acc4 into main Dec 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants